search

davo899 / CobblemonTrainers

Adds a trainer battle system to Cobblemon with challenging trainer AI
Other
1 stars 4 forks source link

add command `setpartymaximumlevel` #12

Closed KiwiFlavoredApollo closed 5 months ago

KiwiFlavoredApollo commented 5 months ago

Added option to set maximum level restriction on player party. The maximum level will range from 1 to 100 and the default value is set to 100.

davo899 commented 5 months ago

Awesome work, thanks for the contribution! I think it could be better to use a BattleStartError in PokemonUtility.startBattle than custom exceptions, startBattle is kind of a misleading name I should have called it startTrainerBattle.

KiwiFlavoredApollo commented 5 months ago

Thank you for the feedback. I'll try rewriting exception handling part using BattleStartError. My rough guess is that PartyEmptyException could be replaced with BattleStartError.Companion.insufficientPokemon.