Fix inheritance issues - Githubissues

davorg-cpan / moox-role-json_ld

Moo role to easily add JSON-LD generation into a class

1 stars 5 forks source link

Fix inheritance issues #13

Closed robrwo closed 5 years ago

robrwo commented 5 years ago

If you have a class that uses MooX::JSON_LD, and another class inherits from that but also uses MooX::JSON_LD, then the role is applied twice, which can break things for the existing classes, especially if you want to override the json_ld_encoder.

This fixes that by checking if all of the expected methods in the role exist. If they do, then it will not apply the role.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 69

9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 96.667%

Totals
Change from base Build 66:	0.3%
Covered Lines:	58
Relevant Lines:	60

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 69

9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 96.667%

Totals
Change from base Build 66:	0.3%
Covered Lines:	58
Relevant Lines:	60

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 69

9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 96.667%

Totals
Change from base Build 66:	0.3%
Covered Lines:	58
Relevant Lines:	60

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 69

9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 96.667%

Totals
Change from base Build 66:	0.3%
Covered Lines:	58
Relevant Lines:	60

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 69

9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 96.667%

Totals
Change from base Build 66:	0.3%
Covered Lines:	58
Relevant Lines:	60

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 69

9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 96.667%

Totals
Change from base Build 66:	0.3%
Covered Lines:	58
Relevant Lines:	60

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 69

9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 96.667%

Totals
Change from base Build 66:	0.3%
Covered Lines:	58
Relevant Lines:	60

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 70

9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 96.667%

Totals
Change from base Build 66:	0.3%
Covered Lines:	58
Relevant Lines:	60

💛 - Coveralls