davorg-cpan / moox-role-json_ld

Moo role to easily add JSON-LD generation into a class
1 stars 5 forks source link

Is Moose needed as a prerequisite? #14

Closed robrwo closed 3 years ago

robrwo commented 5 years ago

Shouldn't Moose be a test prereq?

JJ commented 5 years ago

It's already a build prereq. What do you mean?

robrwo commented 5 years ago

It's not needed for building or running, only for tests. It should be a recommended test prereq so that the test skips if Moose is not installed.

davorg commented 5 years ago

Does ExtUtils::MakeMaker have a way to declare recommended test prereqs?

robrwo commented 5 years ago

Well, at the minimum Moose could be moved from PREREQ_PM to TEST_REQUIRES.

But you may be able to change the META_MERGE for

  prereqs => {
    "recommends" => {  "Moose" => 0 },
  }