search

davosmith / moodle-assignfeedback_pdf

Along with moodle-assignsubmission_pdf, this plugin allows students to submit their work as a PDF, then have the teacher annotate it online, before returning the marked PDF to the student.
3 stars 4 forks source link

Files are not correctly stored in database #5

Closed crazyserver closed 8 years ago

crazyserver commented 8 years ago

Hi Davos,

We're currently working in Submission Status on the Mobile App. We used this plugin to test that 3rd party feedback modules were correctly displayed on the app. We realised that your plugin is using submissionid as item id to store files on the database. All Feedback plugins must use gradeid to be properly shown.

Please check get_assign_feedback_status_renderable function, where you can see how grade is retrieved. Moving those files would allow the app to show them in the app using Moodle 3.1 (or in a future the latest version of local_mobile in any version).

This issue was discovered while developing https://tracker.moodle.org/browse/MOBILE-1593.

Cheers!

Pau

davosmith commented 8 years ago

I'm not going to be implementing any major changes like this to my plugin, as its usage is now deprecated in favour of the core Moodle functionality that is based on it.

Files are stored against the submissionid as they are closely tied to the submission files.

crazyserver commented 8 years ago

Ok, I only want you to know that ;-)