search

davosmith / moodle-checklist

Checklist plugin for Moodle - allows a teacher to create a checklist for their students to tick-off
GNU General Public License v3.0
24 stars 68 forks source link

Adapt mobile code to ionic 7 #125

Closed dpalou closed 3 months ago

dpalou commented 3 months ago

In this PR I updated the HTML to use the new Ionic syntax for inputs. The old syntax still works in the 4.4 version of the app (ionic 7), but it will stop working in the 4.5 version (ionic 8) so some inputs could be wrongly aligned without these changes. To make it easier to review the code, in the first commit I duplicate the template (no changes done in the HTML) and then I apply the changes in a new commit.

I also removed the core-course-module-description component, it is deprecated and will be removed in a future version of the app.

I used to avoid duplicating the HTML of each item's label. This Angular component lets you define some HTML to be reused, and then I use it in 2 places of the template using *ngTemplateOutlet.

davosmith commented 3 months ago

That looks good to me - thanks for this.