Quote service - Githubissues

cpage-pivotal commented 8 years ago

Consolidates to a single endpoint, /quotes?q={symbols}, for looking up stock quotes.

Successfully parses the Yahoo quote responses whether looking up a single quote or multiple quotes.

For all invocations of the quote service, single or multiple, the Yahoo service is the first option. Markitondemand is the fallback option if Yahoo fails.

Xignite support has been removed. Xignite trials only last for 7 days or 250 requests, which is not conducive to a reliable demo environment.

davpin commented 8 years ago

Hi Corby,

Thanks for the PR.

Isn't some of this work done already? I feel like I've done some of this already. A few comments:

we're getting the quotes from Yahoo, but where are we getting the companies list from? still markit? This won't solve the issues we have been having.
There is a parameter to pass in to the jackson reader to treat single element responses as one element arrays. I'm pretty sure I've addressed this before. Saves the if/then/else statement.
I want to keep the API version number in the path, as that will allow multiple version running at the same time, ie keep "v1".

cpage-pivotal commented 8 years ago

I'm working off the current version of the development branch. If you have done this already, it's not in the dev branch.

Fixing the markit companies API is outside the scope of this pull request.

I will update the PR to use Jackson's ACCEPT_SINGLE_VALUE_AS_ARRAY parameter.

It seems like versioning services ('/v1') should be done on all services or none of them. I'm not completely convinced that the scope of this project necessitates supporting multiple versioned instances of each service.

On Thu, Jan 14, 2016 at 1:48 PM, David Ferreira Pinto < notifications@github.com> wrote:

Hi Corby,

Thanks for the PR.

Isn't some of this work done already? I feel like I've done some of this already. A few comments:

-

we're getting the quotes from Yahoo, but where are we getting the companies list from? still markit? This won't solve the issues we have been having.

There is a parameter to pass in to the jackson reader to treat single element responses as one element arrays. I'm pretty sure I've addressed this before. Saves the if/then/else statement.

I want to keep the API version number in the path, as that will allow multiple version running at the same time, ie keep "v1".

— Reply to this email directly or view it on GitHub https://github.com/dpinto-pivotal/cf-SpringBootTrader/pull/51#issuecomment-171758337 .

Corby Page Senior Field Engineer, Pivotal 713.584.3168

davpin / cf-SpringBootTrader

Quote service #51

we're getting the quotes from Yahoo, but where are we getting the companies list from? still markit? This won't solve the issues we have been having.

There is a parameter to pass in to the jackson reader to treat single element responses as one element arrays. I'm pretty sure I've addressed this before. Saves the if/then/else statement.