search

davqvist / CustomAchievements

GNU General Public License v3.0
2 stars 1 forks source link

Compatibility: Rendering crash with The One Probe #3

Closed leagris closed 7 years ago

leagris commented 7 years ago
Versions
NullPointerException Crash

While breaking out a crafting-table trophy, just as the break animation ends and the trophy block is about to turn into an item..

crash-2017-05-19_20.39.40-client.txt

See: https://github.com/McJty/TheOneProbe/issues/163

davqvist commented 7 years ago

Probably an error on my side, I already a similar issue in 1.10.2 which I was sure I fixed, but I maybe didn't or it got reintroduced in 1.11. Thanks for reporting.

davqvist commented 7 years ago

Can't replicate. With what tool did you break the Crafting Table? Did you change the customachievements.json? If yes, can you pastebin it?

leagris commented 7 years ago

Broke it bare hands. Was initial run of the mod, new map.

davqvist commented 7 years ago

Hm, can't replicate it still even with breaking with bare hands. Can you try yourself another time in another test world if you can replicate it? If yes, please tell me exactly what you have done, step by step, and give me your modlist. I appreciate it.

leagris commented 7 years ago

Reproduced it again, without optifine to be sure.

See our modlist here: http://rawgit.com/Beyond-Reality/Beyond-Realty-Farscapes/master/modlist.html

leagris commented 7 years ago

I tested it in two different worlds. The first one Had crashes always when breaking trophy Not that I earned 3 trophy for the crafting table 1 each time I broke/placed it

I continue investigations

leagris commented 7 years ago

@davqvist I think I have identified the bug trigger.

So it might be related to breaking a Trophy while having same Trophy in your inventory. Also I am not sure the achievement's Trophy should trigger multiple-times. Sound more like a bug. Is it intentional?

davqvist commented 7 years ago

I still can't replicate but I'm pretty sure what the problem is anyway. Triggering trophies multiple times is of course not intended and a bug in the port.

Both are fixed in 0.3.1 https://github.com/davqvist/CustomAchievements/commit/cafb67f8236bf0d4d96d6fb588a5b004da856d9c