search

davraamides / todotxt-mode

MIT License
59 stars 12 forks source link

User Settings are cached and don't immediately take effect without a restart #45

Open davraamides opened 2 years ago

davraamides commented 2 years ago

This is in response to Issue #44 submitted by @jowitte. I'm using vscode.workspace.getConfiguration but I'm assigning the settings to a variables so they won't take effect until the extension is restarted. I could just change them all to property setters to fix this.

hukacode commented 2 years ago

Can I pick this task?

My idea is change from export namespace Settings to export class Settings and function getSetting<T>(field: string): T | undefined { to getSetting<T>(field: string): T | undefined { then refactor the rest.

davraamides commented 2 years ago

Sure - that would be great.