search

davraamides / todotxt-mode

MIT License
59 stars 12 forks source link

fix: use extensionDevelopmentPath and extensionTestsPath directly #48

Open hukacode opened 2 years ago

davraamides commented 2 years ago

Hi @hukacode. Thanks for this. But when I test it, I still need to restart VS Code to see the effect of a change to the MarkdownDecorationBeginPattern. I think the issue is that even though you've introduce a class for Settings, in some (most?) places the local instance is only being created once, like in helpers.ts, so if the values are still being cached.

hukacode commented 2 years ago

I'm sorry, I tested with todotxtmode.waitingFilename so I thought it worked. I don't have so much experience with TypeScript. I will try my best later.

davraamides commented 2 years ago

No worries. I appreciate the effort and putting all the settings in a proper class is helpful for other cases. I think the best solution might just be to define property getters and setters for each setting that do not have any class variable - they just return the vscode.workspace.getConfiguration() value each time, like "style" settings do.