davrempe / humor

Code for ICCV 2021 paper "HuMoR: 3D Human Motion Model for Robust Pose Estimation"
MIT License
518 stars 72 forks source link

`class_name_to_file_name` breaks for class names that aren't CamelCase #13

Open gngdb opened 2 years ago

gngdb commented 2 years ago

https://github.com/davrempe/humor/blob/b86c2d9faf7abd497749621821a5d46211304d62/humor/utils/logging.py#L25-L35

For example, AMASSFitDataset is not supported. There might be an elegant way to do this by inspecting the name spaces of all the files in the library that this function should support, but to be honest a hardcoded dictionary might be better because it will at least fail in a predictable and easy to debug way.