davvil
commented
12 years ago I would prefer the second option, as it seems more consistent with the widget policy of gtk.
On 26 May 2012 21:38, "rschroll" < reply@reply.github.com> wrote:
The overview overrides the show() and hide() methods in order to grab the keybord focus (on show) and trigger a recalculation of the structure (on hide). But in cdb136e, the layout was changed so that the overview is not longer shown and hidden; instead its parent is. A few solutions:
- Revert the relevant parts of cdb136e.
- Make the overview connect to show and hide signals of its parent.
- Override the show and hide signals of the overview parent to call relevant methods of the overview.
- Show and hide the overview as well as its parent.
I prefer the first, since it makes the overview completely self-contained. But the second strikes me as nearly as good. The third and fourth seem a bit ugly to me.
Reply to this email directly or view it on GitHub: https://github.com/davvil/pdfpc/issues/16
rschroll
The overview overrides the show() and hide() methods in order to grab the keybord focus (on show) and trigger a recalculation of the structure (on hide). But in cdb136e, the layout was changed so that the overview is not longer shown and hidden; instead its parent is. A few solutions:
I prefer the first, since it makes the overview completely self-contained. But the second strikes me as nearly as good. The third and fourth seem a bit ugly to me.