search

davvil / pdfpc

A presenter console with multi-monitor support for PDF files.
http://davvil.github.com/pdfpc/
GNU General Public License v2.0
210 stars 20 forks source link

Ensure Presenter height never grows beyond screen height #4

Closed rschroll closed 12 years ago

rschroll commented 12 years ago

A full-screen window that has a height greater than the screen height experiences all sorts of weird, wonderful breakage, at least in Gnome 3. I found two ways in which this could happen:

  1. The current view + strict view + bottom bar could be taller than the screen.
  2. The notes view could extend downwards as text was added. These commits fix both issues.
davvil commented 12 years ago

Thanks for the patch!

For the notes I can see the problem is solved. For the slides I do not have a real-life example to work on and test it. Could you PM some slides where the problem occurs? I tried opening a "book" (i.e. several portrait A4 pages) and the window was resized in a strange way, but this is not a case we should concentrate on, I think. Although it should not break there either...

rschroll commented 12 years ago

Try launching a normal presentation with '-u 90'. With a wide-screen monitor, I actually had problems with the default settings. I can send you screenshots, if that would help.

davvil commented 12 years ago

Merged. There may still problems with patological cases though, e.g. when opening A4 pages. With normal usage there shouldn't be issues, but I will add similar checks also for the preview so that pdfpc is more robust.