search

davvil / pdfpc

A presenter console with multi-monitor support for PDF files.
http://davvil.github.com/pdfpc/
GNU General Public License v2.0
210 stars 20 forks source link

Pdfpc doesn't compile under Ubuntu 11.10 #9

Closed rschroll closed 12 years ago

rschroll commented 12 years ago

These are the changes I had to make to get pdfpc to compile in Ubuntu 11.10. They revert some recent changes made in the trunk, and obviously they won't be accepted in their current form. But maybe we can work out some way to make the compilation work with a range of versions.

Some (potentially) relevant versions for 11.10:

(Sorry for the flurry of pull requests -- please take it as a sign of my excitement about pdfpc.)

davvil commented 12 years ago

I'm afraid I won't merge this one. I had to do these changes (in the opposite direction) in order to compile it wich valac 0.16, the newest version. As eventually all distributions should include this or newer versions I don't think it makes much sense to try to support older versions. You are welcome to support a "vala0.14" branch in your repo and I can add a pointer to it in the main README, if you want.

What I would be interested in, is if the source tarball compiles on "older" distributions. The tarball includes an compiles the generated C code, so no vala is needed and the rest of requirements should be fairly standard.

(And don't be afraid to submit as many pull requests as you want, I like it if pdfpc interests people! Next week probably I won't have much time to code, so probably I won't be too active, but afterwards I should be able to spend more time on pdfpc.)

rschroll commented 12 years ago

I just learned how to use the Vala preprocessor to test for the version. Commit 54c6022156 uses this to provide appropriate code for different versions. Maybe you're interested in including that. (I can't seem to attach new code to a closed pull request, sorry.)

BTW, the tarball does compile for me.

davvil commented 12 years ago

I merged/cherry-picked it into the current master, as now it compiles on both versions, old and new (and the changes needed are small!). As a side note, Issue #1 is not present with older vala versions.