search

davy7125 / polyphone

A soundfont editor for quickly designing musical instruments.
https://www.polyphone.io
GNU General Public License v3.0
350 stars 46 forks source link

Polyphone violates the licences of Font-Awesome #106

Closed mirabilos closed 4 years ago

mirabilos commented 4 years ago

Polyphone includes quite a number of SVGs that are taken from Font-Awesome (I’ve got a hard time to figure out from which edition exactly, as that also determines the exact licence to use). However, according to https://github.com/FortAwesome/Font-Awesome/blob/master/LICENSE.txt they all require attribution of some kind.

mirabilos commented 4 years ago

resources/arrow_down.svg comes from svgs/solid/caret-down.svg, so CC-BY 4.0 is the correct licence AFAICT.

mirabilos commented 4 years ago

https://evolvis.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=alioth/polyphone.git;a=commitdiff;h=0e2ba6f702f3814d53b70b4abd6d4bb553273333 are all I found; please indicate whether this is correct, and honour the FA licence upstream.

mirabilos commented 4 years ago

sources/resources/exchange.svg and sources/resources/shield.svg also in git master.

Where does sources/contrib/audio-x-soundfont.svg come from?

davy7125 commented 4 years ago

Thank you for having seen this, I guess the attribution should be found in this file:

I'll check the Windows and Mac installers as well.

When the software is installed, the attribution can be found in the "about" dialog: https://github.com/davy7125/polyphone/blob/master/sources/dialogs/dialog_about.cpp

All icons come from the Awesome Icon set or I designed them (the logo for instance or others like the modulator curves). I'm sure there is no other sets involved so Polyphone is OK on this side.

mirabilos commented 4 years ago

Davy Triponney dixit:

Thank you for having seen this, I guess the attribution should be found in this file:

No, it must be in a file that’s present in the normal source tree, i.e. the one we get via uscan and that’s imported to https://evolvis.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=alioth/polyphone.git;a=tree;h=refs/heads/upstream;hb=refs/heads/upstream

I’m copying that information into the debian/copyright file of the proper Debian package of polyphone (already uploaded for ftpmaster review), so don’t worry about Debian.

When the software is installed, the attribution can be found in the "about" dialog: https://github.com/davy7125/polyphone/blob/master/sources/dialogs/dialog_about.cpp

Ah. Pretty buried there and hard to read, but visible to the end user. It is not sufficient for the source distribution, though, for example the CC-BY-SA licence text isn’t shipped.

All icons come from the Awesome Icon set or I designed them (the logo for instance or others like the modulator curves). I'm sure there is no other sets involved so Polyphone is OK on this side.

OK, good. The new debian/copyright format (and reusers) will need to know which files are which, though (hence why I tried to make a list of fa-originating files) plus the FA licence changed over time.

Thanks, //mirabilos -- I believe no one can invent an algorithm. One just happens to hit upon it when God enlightens him. Or only God invents algorithms, we merely copy them. If you don't believe in God, just consider God as Nature if you won't deny existence. -- Coywolf Qi Hunt

mirabilos commented 4 years ago

Davy Triponney dixit:

https://github.com/davy7125/polyphone/blob/master/sources/dialogs/dialog_about.cpp

I’ve updated my current copyright information from it:

https://evolvis.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=alioth/polyphone.git;a=blob;f=debian/copyright;hb=HEAD