davy7125 / polyphone

A soundfont editor for quickly designing musical instruments.
https://www.polyphone.io
GNU General Public License v3.0
348 stars 46 forks source link

hardcoded assumption to run on little endian #123

Open mirabilos opened 4 years ago

mirabilos commented 4 years ago

sources/core/output/sf2/outputsf2.cpp line 326, for example:

  324     /////////////////////////////////////// BLOC INFO ///////////////////////////////////////
  325     fi.write("LIST", 4);
  326     fi.write((char *)&taille_info, 4);
  327     fi.write("INFO", 4);

(Also, WHY IS THAT FRENCH?!?!?!)

This completely breaks using this on big endian platforms (let alone PDP but pray we’re not going there).