search

davy7125 / polyphone

A soundfont editor for quickly designing musical instruments.
https://www.polyphone.io
GNU General Public License v3.0
348 stars 46 forks source link

Build not reproducible (plus typographic nitpick) #134

Closed mirabilos closed 2 years ago

mirabilos commented 3 years ago

The build process hardcodes the current year:

sources/dialogs/dialog_about.cpp:    QString annee = "2013 -" + QString::number(QDate::currentDate().year());

(it’s also wrong, it must be "2013 - " + or "2013-" + and ideally not - but –)

Given that copyright is only triggert by relevant changes (threshold of originality, creativity requirement) it’s best to only ever update the copyright year manually.

davy7125 commented 2 years ago

You are right! It's currently configured to show "2013 - 2022", I hope you will not open a ticket for this :-)

By the way, I don't know the conditions that are required to add a name in the contributor section but you are helping quite a lot so if you want I can mention you in the contributors

mirabilos commented 2 years ago

No, that’s fine ;-)

@ contributors list: sure, if you want, add mirabilos with tg at debian.org as address. Merci!