davy7125 / polyphone

A soundfont editor for quickly designing musical instruments.
https://www.polyphone.io
GNU General Public License v3.0
348 stars 46 forks source link

Polyphone installer on Windows does not supply the Visual C/C++ 2013 redistributables (msvcr120.dll) #145

Closed zeta0134 closed 2 years ago

zeta0134 commented 2 years ago

On a fresh install of Polyphone 2.2, on Windows 10, launching the program produced a warning message (which I neglected to screenshot, so sorry!) which complains about a missing "msvcr120.dll" file. This warning repeats 4 times, and then the program exits.

This file is provided by the following package, which the user currently needs to discover and install manually:

https://www.microsoft.com/en-us/download/details.aspx?id=40784

Since Polyphone is already using an install flow on Windows, logically it would seem to make sense to include this redistributable as part of the installer. If license terms do not permit this (perhaps the proprietary redistributable somehow conflicts with GPL?) then instead the download / release pages should mention this requirement for Windows users.

davy7125 commented 2 years ago

Thank you for the notice. I'll build a new version of Polyphone next month and I'll take care of this All dependencies should be included in the installer

davy7125 commented 2 years ago

Installers for version 2.2 are now fixed