search

davy7125 / polyphone

A soundfont editor for quickly designing musical instruments.
https://www.polyphone.io
GNU General Public License v3.0
344 stars 45 forks source link

modulator targeting sample offset doesn't play in Polyphone #182

Closed mrbumpy409 closed 5 months ago

mrbumpy409 commented 5 months ago

I thought I had reported this bug a while back on the forum already, but I couldn't find it, so I am reporting it here.

Any modulator targeting sample offset doesn't play in Polyphone, but does work correctly in players such as FluidSynth.

Steps to Reproduce

  1. Download and open the following SoundFont in Polyphone: sample-offset-test.zip
  2. Play each of the presets, using different velocities. Each preset uses a velocity→sample start offset modulator at the instrument level so that the amount of sample offset changes with velocity. This should change the sound of the note start, making it brighter at higher velocities.

Result

Polyphone ignores the velocity→sample start offset modulator, so no change to tone is heard when playing different velocities.

Expected Result

Notes should start brighter at higher velocites. To compare, Fluidsynth and current BASSMIDI both play this SoundFont correctly.

davy7125 commented 5 months ago

Again, thank you for this one

mrbumpy409 commented 5 months ago

Thank you good sir for the fixes! I have successfully compiled current master after adjusting the instructions for Qt6 (fortunately, I am on KDE neon with updated Qt6 libraries), and I can verify the issue is indeed resolved.

coderofsalvation commented 4 months ago

awesome, thanks for the fix. Sample offset allows for various creative use cases, for example triggering a ghostsnare from a snare, by moving the offset towards the middle of the snare e.g.