Build error of polyphone 2.4.0 on Fedora 40

ycollet commented 1 month ago

I am trying to build polyphone 2.4.0 on Fedora 40 and I met the following error message:

gcc 14.2.1

qt: 5.15.14

g++ -c -pipe -std=c++17 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -pthread -Wall -Wextra -D_REENTRANT -fPIC -DUSE_LOCAL_RTMIDI -DUSE_LOCAL_QCUSTOMPLOT -DUSE_LOCAL_RTAUDIO -DSOFT_VERSION=\"2.4.0\" -DIDENTIFIER=\"\" -DCURRENT_YEAR=\"2024\" -D__LINUX_ALSASEQ__ -D__UNIX_JACK__ -D__LINUX_ALSA__ -DSFTOOLS_NOXML -D_REENTRANT -DWITH_GZFILEOP -DQT_NO_DEBUG -DQT_PRINTSUPPORT_LIB -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_TESTLIB_LIB -DQT_CORE_LIB -DQT_TESTCASE_BUILDDIR='"/home/collette/rpmbuild/BUILD/polyphone-2.4.0/sources"' -I. -Ilib/_option_rtaudio -Ilib/_option_rtaudio/rtaudio/include -Ilib/_option_rtmidi -Ilib -Imainwindow -Idialogs -Icontext -Icontext/interface -Ieditor -Ieditor/footers -Ieditor/graphics -Ieditor/modulator -Ieditor/overview -Ieditor/tools -Ieditor/widgets -Ieditor/tree -Iresources -Icore -Icore/input -Icore/output -Icore/model -Icore/sample -Icore/types -Iclavier -Isound_engine -Isound_engine/elements -Irepository -Irepository/browser -Irepository/daily -Irepository/widgets -Irepository/user -Irepository/soundfont -Irepository/soundfont/viewer -Irepository/soundfont/editor -Ilib/qtsingleapplication -Iextensions -Iplayer -I. -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/qt5 -I/usr/include/qt5/QtPrintSupport -I/usr/include/qt5/QtSvg -I/usr/include/qt5/QtWidgets -I/usr/include/qt5/QtGui -I/usr/include/qt5/QtNetwork -I/usr/include/qt5/QtTest -I/usr/include/qt5/QtCore -I. -I. -I/usr/lib64/qt5/mkspecs/linux-g++ -o sampleutils.o core/sample/sampleutils.cpp
core/sample/sampleutils.cpp: In static member function ‘static QVector<float> SampleUtils::resampleMono(QVector<float>, double, quint32)’:
core/sample/sampleutils.cpp:76:54: error: no matching function for call to ‘qMin(double, float)’
76 |             pos1 = static_cast<qint32>(qMax(0.f, qMin(floor(delta), 2047.f)) + .5f);
  |                                                  ~~~~^~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/qt5/QtCore/qalgorithms.h:43,
             from /usr/include/qt5/QtCore/qlist.h:43,
             from /usr/include/qt5/QtCore/QList:1,
             from core/types/idlist.h:28,
             from core/types/basetypes.h:28,
             from core/sample/sampleutils.h:28,
             from core/sample/sampleutils.cpp:25:
/usr/include/qt5/QtCore/qglobal.h:673:27: note: candidate: ‘template<class T> constexpr const T& qMin(const T&, const T&)’
673 | constexpr inline const T &qMin(const T &a, const T &b) { return (a < b) ? a : b; }
  |                           ^~~~
/usr/include/qt5/QtCore/qglobal.h:673:27: note:   template argument deduction/substitution failed:
core/sample/sampleutils.cpp:76:54: note:   deduced conflicting types for parameter ‘const T’ (‘double’ and ‘float’)
76 |             pos1 = static_cast<qint32>(qMax(0.f, qMin(floor(delta), 2047.f)) + .5f);
  |                                                  ~~~~^~~~~~~~~~~~~~~~~~~~~~
core/sample/sampleutils.cpp:77:54: error: no matching function for call to ‘qMin(double, float)’
77 |             pos2 = static_cast<qint32>(qMax(0.f, qMin(ceil (delta), 2047.f)) + .5f);
  |                                                  ~~~~^~~~~~~~~~~~~~~~~~~~~~
/usr/include/qt5/QtCore/qglobal.h:673:27: note: candidate: ‘template<class T> constexpr const T& qMin(const T&, const T&)’
673 | constexpr inline const T &qMin(const T &a, const T &b) { return (a < b) ? a : b; }
  |                           ^~~~
/usr/include/qt5/QtCore/qglobal.h:673:27: note:   template argument deduction/substitution failed:
core/sample/sampleutils.cpp:77:54: note:   deduced conflicting types for parameter ‘const T’ (‘double’ and ‘float’)
77 |             pos2 = static_cast<qint32>(qMax(0.f, qMin(ceil (delta), 2047.f)) + .5f);
  |                                                  ~~~~^~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:6454: sampleutils.o] Error 1
make: *** Waiting for unfinished jobs....
g

ycollet commented 1 month ago

Thanks a lot !

ariutti commented 1 month ago

Same issue here on Ubuntu Studio 22.04 (trying to compile Polyphone 2.4.0):

core/sample/sampleutils.cpp: In static member function ‘static QVector<float> SampleUtils::resampleMono(QVector<float>, double, quint32)’:
core/sample/sampleutils.cpp:76:54: error: no matching function for call to ‘qMin(double, float)’
   76 |             pos1 = static_cast<qint32>(qMax(0.f, qMin(floor(delta), 2047.f)) + .5f);
      |                                                  ~~~~^~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qalgorithms.h:43,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:43,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QList:1,
                 from core/types/idlist.h:28,
                 from core/types/basetypes.h:28,
                 from core/sample/sampleutils.h:28,
                 from core/sample/sampleutils.cpp:25:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qglobal.h:671:27: note: candidate: ‘template<class T> constexpr const T& qMin(const T&, const T&)’
  671 | constexpr inline const T &qMin(const T &a, const T &b) { return (a < b) ? a : b; }
      |                           ^~~~
/usr/include/x86_64-linux-gnu/qt5/QtCore/qglobal.h:671:27: note:   template argument deduction/substitution failed:
core/sample/sampleutils.cpp:76:54: note:   deduced conflicting types for parameter ‘const T’ (‘double’ and ‘float’)
   76 |             pos1 = static_cast<qint32>(qMax(0.f, qMin(floor(delta), 2047.f)) + .5f);
      |                                                  ~~~~^~~~~~~~~~~~~~~~~~~~~~
core/sample/sampleutils.cpp:77:54: error: no matching function for call to ‘qMin(double, float)’
   77 |             pos2 = static_cast<qint32>(qMax(0.f, qMin(ceil (delta), 2047.f)) + .5f);
      |                                                  ~~~~^~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qalgorithms.h:43,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:43,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QList:1,
                 from core/types/idlist.h:28,
                 from core/types/basetypes.h:28,
                 from core/sample/sampleutils.h:28,
                 from core/sample/sampleutils.cpp:25:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qglobal.h:671:27: note: candidate: ‘template<class T> constexpr const T& qMin(const T&, const T&)’
  671 | constexpr inline const T &qMin(const T &a, const T &b) { return (a < b) ? a : b; }
      |                           ^~~~
/usr/include/x86_64-linux-gnu/qt5/QtCore/qglobal.h:671:27: note:   template argument deduction/substitution failed:
core/sample/sampleutils.cpp:77:54: note:   deduced conflicting types for parameter ‘const T’ (‘double’ and ‘float’)
   77 |             pos2 = static_cast<qint32>(qMax(0.f, qMin(ceil (delta), 2047.f)) + .5f);
      |                                                  ~~~~^~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:6432: sampleutils.o] Error 1

ariutti commented 1 month ago

Tried to compile the source from a repo clone (instead of source_code_link from web site). Problem seems to be partially solved.

Now I'm stuck here:

player/playerpresetlist.cpp: In member function ‘int PlayerPresetList::columnCount()’:
player/playerpresetlist.cpp:58:29: error: ‘ceil’ was not declared in this scope
   58 |     return static_cast<int>(ceil((double)this->viewport()->width() / _minCellWidth) + 0.5);
      |                             ^~~~
player/playerpresetlist.cpp:58:29: note: suggested alternatives:
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject.h:59,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:45,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qframe.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractscrollarea.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractitemview.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qlistview.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QListView:1,
                 from player/playerpresetlist.h:28,
                 from player/playerpresetlist.cpp:25:
/usr/include/c++/11/chrono:976:7: note:   ‘std::chrono::ceil’
  976 |       ceil(const time_point<_Clock, _Dur>& __tp)
      |       ^~~~
/usr/include/c++/11/chrono:360:7: note:   ‘std::chrono::ceil’
  360 |       ceil(const duration<_Rep, _Period>& __d)
      |       ^~~~
make: *** [Makefile:9120: playerpresetlist.o] Error 1

davy7125 commented 1 month ago

I just commited 2b03ac9 that should fix this problem. Could you please try again?

ycollet commented 1 month ago

I compiled the master branch on Fedora and everything went fine on my side.

davy7125 / polyphone

Build error of polyphone 2.4.0 on Fedora 40 #213