search

davydovanton / shallow_attributes

Simple and lightweight Virtus analog.
MIT License
101 stars 18 forks source link

Ruby 2.4.0 compatibility #10

Closed tatey closed 7 years ago

tatey commented 7 years ago

Tests are 💚. Only issue is coveralls depends on simplecov and simplecov is throwing Fixnum deprecation warnings. There's a fix in the pipeline at https://github.com/lemurheavy/coveralls-ruby/pull/117. This doesn't affect ShallowAttributes at runtime.

I also removed the patch releases from the ruby versions in the README. They were mismatched against .travis.yml and people are really only interested in major and minor versions.

screen shot 2017-03-18 at 9 45 52 am
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.9%) to 100.0% when pulling 64bbe3c2e8ebf5216806670fb2f4fb48dc0fb49b on tatey:ruby-2.4.0 into 3740a540e457b48e4867781039ab44fad14e10d1 on davydovanton:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.9%) to 100.0% when pulling 64bbe3c2e8ebf5216806670fb2f4fb48dc0fb49b on tatey:ruby-2.4.0 into 3740a540e457b48e4867781039ab44fad14e10d1 on davydovanton:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.9%) to 100.0% when pulling 64bbe3c2e8ebf5216806670fb2f4fb48dc0fb49b on tatey:ruby-2.4.0 into 3740a540e457b48e4867781039ab44fad14e10d1 on davydovanton:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.9%) to 100.0% when pulling 64bbe3c2e8ebf5216806670fb2f4fb48dc0fb49b on tatey:ruby-2.4.0 into 3740a540e457b48e4867781039ab44fad14e10d1 on davydovanton:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 99.231% when pulling 64bbe3c2e8ebf5216806670fb2f4fb48dc0fb49b on tatey:ruby-2.4.0 into 3740a540e457b48e4867781039ab44fad14e10d1 on davydovanton:master.

davydovanton commented 7 years ago

Thanks for this patch! 👍