search

davydovanton / shallow_attributes

Simple and lightweight Virtus analog.
MIT License
101 stars 18 forks source link

Default values can be derived from private methods #18

Closed tatey closed 6 years ago

tatey commented 6 years ago

Hello there,

This patch makes it so default values can be derived by private methods as well continuing to support public methods.

In our usage of ShallowAttributes we'd prefer to keep default values as private methods since they have no purpose beyond initailization. We have found you can still test these methods indirectly by testing initialization.

All feedback welcome.

Cheers, Tate

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 99.51% when pulling 58c64094225f7883034babb9822fdfd850bcf4b1 on fivegoodfriends:private-default-values into 4e8a276bfecd115f3cf1057719e04d7c67dace3b on davydovanton:master.

tatey commented 6 years ago

Glad you like the patch. A new release would be wonderful 😄