annoying falling test - Githubissues

davydovanton / shallow_attributes

Simple and lightweight Virtus analog.

MIT License

101 stars 18 forks source link

annoying falling test #28

Closed morr closed 5 years ago

morr commented 5 years ago

In rubies 2.5+ it does not fail anymore when parsing bad strings

[7] pry(main)> Class.new.to_s
"#<Class:0x00007fb6d9455ed8>"
[8] pry(main)> ::Time.parse Class.new.to_s
2000-01-01 00:00:00 +0300

coveralls commented 5 years ago

Coverage decreased (-0.0003%) to 99.878% when pulling 4938013f2b80f1bb7dc66ff5627fdffd4c80620e on morr:remove-test into 37fe19415397c78fcc40c562ea6b0b0b7c47cb16 on davydovanton:master.

coveralls commented 5 years ago

Coverage decreased (-0.0003%) to 99.878% when pulling 4938013f2b80f1bb7dc66ff5627fdffd4c80620e on morr:remove-test into 37fe19415397c78fcc40c562ea6b0b0b7c47cb16 on davydovanton:master.

coveralls commented 5 years ago

Coverage decreased (-0.0003%) to 99.878% when pulling 4938013f2b80f1bb7dc66ff5627fdffd4c80620e on morr:remove-test into 37fe19415397c78fcc40c562ea6b0b0b7c47cb16 on davydovanton:master.

morr commented 5 years ago

nevermind. it seems it does fail on my pc only