search

davydovanton / shallow_attributes

Simple and lightweight Virtus analog.
MIT License
101 stars 18 forks source link

Update documentation for base class functionality #8

Closed davydovanton closed 7 years ago

davydovanton commented 7 years ago

We need to update our documentation for this case https://github.com/davydovanton/shallow_attributes/pull/7/files#diff-aa8cb646f17ea5eb573d32dbcc6a9b86R25. That is all 👍

tatey commented 7 years ago

I'm happy to put my hand up to write this. I actually enjoy writing documentation. You have already written a really nice README 😄

Do you see this going in https://github.com/davydovanton/shallow_attributes#using-shallowattributes-with-classes, or does it get its own section?

davydovanton commented 7 years ago

@tatey I think Using ShallowAttributes with Classes section will be okay 👍