search

dawenxi-tech / 2fa

A 2FA desktop application.
MIT License
2 stars 1 forks source link

packing in ci #24

Open gedw99 opened 9 months ago

gedw99 commented 9 months ago

packaging for Mac ( DMG ) , windows and linux

activated for Mac only as I only has a Mac, and it works on laptop and in ci.

Have not worked out out where I want to release to. For now I guess GitHub release tags.

@heramerom @DawenxiTech

If you want to try locally then turn it on in the make file, and if it works then it will work in ci.

heramerom commented 9 months ago

Thanks, that's works perfect on my laptop.

gedw99 commented 9 months ago

thanks for letting me know it works on your laptop. Windows or Mac . amd64 right ?

If you can get it running in CI then ? Just edit the makefile and CI will do it, but only on a git tag push..

We need to still modify the GitHub ci to release artefacts btw..

gedw99 commented 9 months ago

https://github.com/dawenxi-tech/2fa/blob/main/Makefile#L234C5-L234C5

and

https://github.com/dawenxi-tech/2fa/blob/main/Makefile#L282

heramerom commented 9 months ago

I'm on macos amd64. Thank you.

I don't know how to do, I give you admin rights and you can push tags now.

gedw99 commented 9 months ago

It’s already on in CI. So I don’t need Admin rights.

just modify the make file so that windows is included in the build and pack targets. You can see how its sniffs what OS is running and then calls the is specific make target for build and package.

Just follow my lead of how I setup the make file and go for it.

I think the way the make file works is a decent technique. Mac does full build, package currently locally and in CI.

release is not quite there yet :) we get that working later ..

Can you try it and let me know. I am pretty busy with travel / work stuff in the UK right now, but can help if you get stuck.

heramerom commented 9 months ago

Yeah, thank you! I'm tried and it works perfect on my macos amd64.

Have a nice trip!