search

dawidd6 / action-debian-package

:gear: A GitHub Action for building Debian packages
MIT License
24 stars 8 forks source link

github actions: run test action on all branches #66

Closed SebKuzminsky closed 1 year ago

SebKuzminsky commented 1 year ago

This would have helped me find the problem with my "apt-get without -t" branch earlier.

SebKuzminsky commented 1 year ago

This PR failed because I messed with apt-get -t, the fix for that is in #67.

dawidd6 commented 1 year ago

I would like to keep it that way, only run CI on push to master + on pull_request. Seems to be optimal for me.

SebKuzminsky commented 1 year ago

The downside is that it makes it inconvenient to test my branch before opening the PR, which leads me to offer untested PRs. When those fail (like my broken first attempt at apt-get without -t) it wastes your time.

I don't see what the downside is to testing all branches.

This is not a huge deal to me and I respect your decision. I have a commit in my local repo that turns on testing of all branches, I just have to remember to include it in bugfix- and feature-branches during testing, and remove it before opening the PR.

dawidd6 commented 1 year ago

Just open the PR as a draft.

SebKuzminsky commented 1 year ago

Ah, yeah that would work. Thanks!