search

dawidd6 / action-debian-package

:gear: A GitHub Action for building Debian packages
MIT License
24 stars 8 forks source link

Let caller pass in extra options to `docker create` #71

Open sebastiankuzminsky opened 1 year ago

sebastiankuzminsky commented 1 year ago

The "normal" way to run Github Actions in docker is to use jobs.<job_id>.container. This lets the user pass extra args to docker create using jobs.<job_id>.container.options. We in the LinuxCNC project use this to enable some extra capabilities we need for testing inside the container: https://github.com/LinuxCNC/linuxcnc/blob/master/.github/workflows/ci.yml#L66-L75.

But the Github ubuntu-* runners do not have qemu-user-static installed, so you can only run docker containers of the native CPU architecture.

I really want to use action-debian-package because it installs qemu-user-static, so it supports building on different CPU architectures. But it doesn't support options, so our test suite can't run.

This issue is a feature request: please add a way for the user to specify extra options to docker create.

dawidd6 commented 7 months ago

Will accept a PR adding this.