dawidd6 / action-send-mail

:gear: A GitHub Action to send an email to multiple recipients
MIT License
443 stars 186 forks source link

Underscore in URL breaks links in google groups #171

Closed NotMyFault closed 1 year ago

NotMyFault commented 1 year ago

Hey,

I'm using the following setup:

jobs:
  post:
    runs-on: ubuntu-latest
    steps:
      - name: Send mail
        uses: dawidd6/action-send-mail@v3
        with:
          server_address: smtp.gmail.com
          server_port: 465
          username: ${{secrets.MAIL_USERNAME}}
          password: ${{secrets.MAIL_PASSWORD}}
          secure: true
          subject: ${{ github.event.release.tag_name }} has been released
          to: demo@googlegroups.com
          from: Release Bot
          html_body: ${{ github.event.release.body }}
          convert_markdown: true

with this release text:

Download the release from: https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.401.3-rc33578.5f3947a_c72fc/jenkins-war-2.401.3-rc33578.5f3947a_c72fc.war

but the underscore (7a_c) breaks the rendering of the URL in the message posted in google groups: Screenshot 2023-07-19 at 08 56 44 Everything else looks good as intended.

dawidd6 commented 1 year ago

Are you wrapping your URL in markdown? https://anvilproject.org/guides/content/creating-links

NotMyFault commented 1 year ago

Are you wrapping your URL in markdown? anvilproject.org/guides/content/creating-links

No, I was using the direct URL. Using wrappring works.

dawidd6 commented 1 year ago

Closing then