dawnbeen / c_formatter_42

C language formatter for 42 norminette
GNU General Public License v3.0
176 stars 17 forks source link

We could add the feature of adding ft_ when function name is missing it #41

Closed kmbenjel closed 2 years ago

kmbenjel commented 2 years ago

I think it's an excellent feature to add, even if it's not part of the subject of c_formatter, but it's close to it and enjoyable.

cacharle commented 2 years ago

hmm, I haven't been in school in a while, does the norm require functions to be prefixed with ft_ now?

Otherwise I think its a terrible idea.

Only public functions of a library should have a common prefix (so for school, it only makes sense for libft). For regular programs where it's functions are not used by anything else other than that program, I think adding a prefix is confusing (maybe adding a prefix for the module of that function makes sense), as it implies you re using a function from a library and not one from your program.

kmbenjel commented 2 years ago

Sure it does not, yeah I look about Libft for now as I'm still on it. You could just miss ft_ in its required functions so I thought it could be a nice idea, not to generalize it for auxiliary functions, of course.