search

dawnericarobles / homework-relaxer

0 stars 0 forks source link

Feedback for Assignment #3 #2

Open barryross opened 8 years ago

barryross commented 8 years ago

FEWD Week #3 Project: CSS Layouts

Description

Relaxr was really impressed by your work last week and wants you to continue development on their landing page. Starting in class, you will work to build out a more complex layout for their company site. They decided on creating a blog, and their back-end engineers will be focused on developing the blog's functionality. They want your front-end skills to style their designs using HTML and CSS so Relaxr's engineers can begin integrating. Once again, the designers have handed you a basic design file with instructions and the JPEG below to help you bring the blog to life. Submit the finished version for homework.

Student: Dawn Robles

Project URL: https://github.com/dawnericarobles/homework-relaxer
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use in-line-block or floats in your CSS to achieve a two-column layout x
Use the correct Open Sans Google Font typeface to style the text denoted in the design file and according to the JPEG provided x
Use proper filename conventions (lowercase, .html) x
Use a single external CSS stylesheet to style all pages x
Use a background image for the headers x
Add a hover effect to all the links using pseudo-classes x
Integrate drop caps using pseudo-classes x
TOTAL: 12/14
barryross commented 8 years ago

Hey Dawn,

Excellent work on this assignment! A lot of really great stuff going on here!

A couple things regarding the points above. I gave both points for the filenaming conventions, but I did want to point out something regarding ID/Class names as I did see a case where you used capitals in the id name of id="Category"

Please remember to be consistent throughout...overall though, they look pretty consistent! I do want to encourage you to start using hyphenated versions of multi-word names for IDs & Classes in your HTML & CSS, like multi-word, instead of 'multiWord' . Let's save camelCase for the JavaScript variables, functions etc.

I do see that you used a:link and a:visited, which is awesome! Unfortunately, the assignment was specifically asking for a:hover .

barryross commented 8 years ago

BTW, I really like seeing so many commits !