search

dawnlabs / alchemy

:crystal_ball: File conversion, all from the menu bar
https://dawnlabs.github.io/alchemy
MIT License
926 stars 71 forks source link

Adding support for converting from HEIC? #56

Open coffeylukas opened 5 years ago

coffeylukas commented 5 years ago

It would be SUPER helpful to have a conversion from HEIC to JPEG. iPhone images are stored in HEIC (this is changeable in iPhone settings, but using the less efficient images takes up more space), and converting them is always a hassle. Alchemy is already awesome, but it would be more awesome to convert from HEIC to at least JPEG.

mfix22 commented 5 years ago

Hey @coffeylukas great idea! Would you have any interest in working on this? 🙂 Otherwise we can mark it up for prioritization for future releases.

mfix22 commented 5 years ago

For reference for whoever ends up working on this, this package could be useful for Decoding the HEIC image: https://godoc.org/github.com/jdeng/goheif

jonahisadev commented 5 years ago

I know this is kind of old and I'll be busy for the next several days, but I'd be interested in trying to add this feature. Should this be integrated with photosorcery first?

mfix22 commented 5 years ago

@jonahisadev that would be amazing!! 🙏 it might be better/easier to add it to photosorcery first, but I’d accept a PR that handles it without that.

Thank you in advance!

jonahisadev commented 5 years ago

For sure! I'm largely working on Linux, so I'll probably start by adding the fix to photosorcery and then adding the change here

mfix22 commented 5 years ago

Tremendous!! 🎉

mfix22 commented 5 years ago

@jonahisadev hey Jonah 👋 are you still working on this feature? I'd love to include it in the next release! 👌 No rush, just wanted to check in.

jonahisadev commented 5 years ago

@mfix22 Back when I started trying to work on it I think I ran into some problems with Docker so I gave up for a few days and then work got crazy so I forgot. I should have a couple hours tonight to try again. I'll first add it to photosorcery and then to alchemy 👍

mfix22 commented 5 years ago

@jonahisadev no worries if not — just wanted to check in 👍

jonahisadev commented 5 years ago

@mfix22 I just wanted to give you an update: unfortunately, this week has been very busy again, and I'll be moving back to school soon so I don't have time to work on this still. Unless someone else gets this, you'll have to leave it out for the next release. When I have some more free time on my hands I'll come back to this and see if it still needs implementing