dawoe / OEmbed-Picker-Property-Editor

Property editor for Umbraco CMS to allow embedding 3rd party media like Youtube, Vimeo, ... outside of the rich text editor.
https://our.umbraco.org/projects/backoffice-extensions/oembed-picker-property-editor/
MIT License
10 stars 10 forks source link

UI improvements #5

Closed ronaldbarendse closed 3 years ago

ronaldbarendse commented 4 years ago

The current Add-button seems a bit off compared to other pickers:

Current add button

Changing it to be like this would look better:

New add button

Also, when only a single item can be selected, the drag-and-drop handle is still shown (maybe to move it over to another property?) and on smaller screens/larger previews, the Remove-button isn't (completely) shown:

afbeelding

ronaldbarendse commented 4 years ago

And there's no background while dragging the item:

Dragging

ronaldbarendse commented 4 years ago

And there's no background while dragging the item:

Dragging

Looks like this is a problem in Umbraco core, as I also see this when dragging document types in the Nested Content data type editor...

dawoe commented 4 years ago

Hi @ronaldbarendse

Thanks for the feedback. I will keep this open for a next version. I have seen some work being done in core to be able to edit embeds.

But if you are up to it... I accept pull requests 😄

TRexStark commented 3 years ago

Hi @dawoe

I have styled the property in a test project I have and it looks like the below as an example. I can commit the files if you want to merge them.

There is a new stylesheet added and the view markup changed slightly

Screen Shot 2020-08-30 at 1 06 35 pm
dawoe commented 3 years ago

Hi @TRexStark

Could you make a PR for this. Looks awesome.

Dave

dawoe commented 3 years ago

This is fixed by #7