dawoe / OEmbed-Picker-Property-Editor

Property editor for Umbraco CMS to allow embedding 3rd party media like Youtube, Vimeo, ... outside of the rich text editor.
https://our.umbraco.org/projects/backoffice-extensions/oembed-picker-property-editor/
MIT License
10 stars 10 forks source link

Updated the property's look and feel #7

Closed TRexStark closed 3 years ago

TRexStark commented 3 years ago
dawoe commented 3 years ago

Hi @TRexStark

Thanks for the PR. I will try to find sometime this week to review it.

Stay tuned.

Dave

dawoe commented 3 years ago

Hi @TRexStark

Just wanted to let you know that I am a bit swamped with work lately, but I still have this on my radar.

Will try to review this one later this week.

Dave

TRexStark commented 3 years ago

No worries @dawoe I'm planning to submit another Pull Request, I'm just testing it on a client site and will compile it hopefully later this week.

dawoe commented 3 years ago

Hi @TRexStark

First of all the updates look great. But I noticed some small issues when using it as a single picker.

image

It still shows the sorting icon and it shows a empty square box when a video is picked

Could you have a look at that ?

Dave

FransdeJong commented 3 years ago

Is there a way to detect if it's in single mode in the view? A added class when in singlemode or something? It's possible that I'm just overlooking it but I can't seem to find it.

TRexStark commented 3 years ago

Hi @TRexStark

First of all the updates look great. But I noticed some small issues when using it as a single picker.

image

It still shows the sorting icon and it shows a empty square box when a video is picked

Could you have a look at that ?

Dave

I will look into that no worries.

TRexStark commented 3 years ago

Hi @TRexStark

First of all the updates look great. But I noticed some small issues when using it as a single picker.

image

It still shows the sorting icon and it shows a empty square box when a video is picked

Could you have a look at that ?

Dave

Hi @dawoe That has been fixed.

dawoe commented 3 years ago

Hi @TRexStark

This looks great. I will merge this one and release a new version of the package