search

dawonn / vectornav

ROS Interface for the VectorNav IMU/GPS
145 stars 175 forks source link

Uncommented code blocks in parseGpsGroup function #129

Closed christomaszewski closed 1 year ago

christomaszewski commented 1 year ago

Uncommented the code blocks that parse gps week and position ecef from the composite data object because they seem to be supported by current vectornav programming library. Spent hours beating my head against my code trying to figure out why position ecef was not being published on the gps ros topic haha!

dawonn commented 1 year ago

Thanks for the PR!

How was this tested?

christomaszewski commented 1 year ago

I gathered a rosbag yesterday using a vn200 connected to a Jetson tx2. I can provide the rosbag if needed but also if you check out the vn200 programming library these functions are now available: https://github.com/dawonn/vectornav/blob/92c02e8d5902a97681a82befc718a15e4ee2bad3/vectornav/vnproglib-1.2.0.0/cpp/include/vn/compositedata.h#L314

I think the ros1 version of this library already uses this function so my guess is the comment is left over from when the library was using an older version of the vectornav programming library.

On Sat, Aug 19, 2023 at 08:25 Dereck Wonnacott @.***> wrote:

Thanks for the PR!

How was this tested?

— Reply to this email directly, view it on GitHub https://github.com/dawonn/vectornav/pull/129#issuecomment-1684932957, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALNWGXIPBGZZ3UJNBZII6TXWCWFPANCNFSM6AAAAAA3VSRPGM . You are receiving this because you authored the thread.Message ID: @.***>

-- Sincerely,

Christopher Tomaszewski (973) 641-0694