dawoudt / JustWatchAPI

Python 3 JustWatch.com API - https://justwatch.com
MIT License
326 stars 45 forks source link

get_providers() and other methods no longer supported? #20

Closed drexeljoe closed 6 years ago

drexeljoe commented 6 years ago

I followed the sample code on the main Git page to install and test out the justwatch module. Very quickly I ran into an error, where one of the methods does not appear to exist.

--verify python version $ python3 --version Python 3.7.1

--install module $ python3 -m pip install JustWatch

--verify module version $ pip3 show justwatch Name: JustWatch Version: 0.4.1 Summary: A simple api for justwatch.com Home-page: https://github.com/dawoudt/JustWatchAPI

--enter python3 and attempt to use $ python3 >>> from justwatch import JustWatch >>> just_watch = JustWatch(country='US') >>> provider_details = just_watch.get_providers() Traceback (most recent call last): File "<stdin>", line 1, in <module> AttributeError: 'JustWatch' object has no attribute 'get_providers'

When I list the methods of the created object, several I expect to see are missing and attempted use of them returns a similar error as above about the attribute not existing. Were these recently removed?

>>> dir(just_watch) ['__class__', '__delattr__', '__dict__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__le__', '__lt__', '__module__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', 'country', 'kwargs', 'language', 'search_for_item']

draogn commented 6 years ago

Looks like the version via pip is out of date. Looking here there needs to be an update to the version number in setup.py and another upload to PyPi. @dawoudt is this something you can do?

dawoudt commented 6 years ago

@draogn, @drexeljoe this has been on my todo list for a while now. Will repackage and publish to pypi as soon as i get to a terminal. Sorry for the delay

dawoudt commented 6 years ago

@drexeljoe this has been resolved. Try installing JustWatch 0.5.0 and let us know how you go :)

drexeljoe commented 6 years ago

Awesome! Thanks for the quick resolution, @dawoudt. I can confirm that the following methods are now returning data: