search

dawsbot / drain

🫗 Drain a wallet of tokens FAST
https://drain-tokens.vercel.app/
129 stars 79 forks source link

Login With Unstoppable Domain integration #1

Closed ayush035 closed 2 years ago

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drain ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 2:03PM (UTC)
dawsbot commented 2 years ago

Hey @ayush035, thanks for the PR.

Unfortunately I don't understand the use-case because the unstoppable button you've added presents the users with the same options (MetaMask or WalletConnect). In addition, this integration adds 133kb from @uauth/js which slows down the site for folks in emerging markets.

Help me understand what this new button adds for users.

ayush035 commented 2 years ago

Of course , Unstoppable Domain is a NFT domain That has information to your every wallet and if you connect Via Unstoppable Domain you won't have to enter that long and complex Wallet Addresses no more and Just enter your Domain name that you get From Unstoppable . It helps tp speed up the transactions and make them hassel free .

On Wed, 24 Aug, 2022, 10:11 pm Dawson Botsford, @.***> wrote:

Hey @ayush035 https://github.com/ayush035, thanks for the PR.

Unfortunately I don't understand the use-case because the unstoppable button you've added presents the users with the same options (MetaMask or WalletConnect). In addition, this integration adds 133kb for @uauth/js which slows down the site for folks in emerging markets.

Help me understand what this new button adds for users.

— Reply to this email directly, view it on GitHub https://github.com/dawsbot/drain/pull/1#issuecomment-1225973026, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR74PDNZ2QFTLKDV33TXCMTV2ZGC3ANCNFSM57NB6XYQ . You are receiving this because you were mentioned.Message ID: @.***>

dawsbot commented 2 years ago

@ayush035 Luckily, on Drain, you never need to type out any addresses. When you connect via MetaMask or WalletConnect, Drain pulls in your address.

Is there anything I misunderstand here?

It seems there's an Unstoppable Domain wallet that is now usable thanks to this PR? If that's the case, can you instead connect to that wallet via WalletConnect?

ayush035 commented 2 years ago

Yes ,But you need to type in the wallet address while transfer of the fund right? why don't just type in the Domain name instead of whole address as it has all your addresses stored in it. Ofcourse I've only added Login and not this, till now. If you click on that login bhi Unstoppable domain Button It will show you Many types of wallet over there and it includes wallet connect .

On Thu, 25 Aug, 2022, 12:14 am Dawson Botsford, @.***> wrote:

@ayush035 https://github.com/ayush035 Luckily, on Drain, you never need to type out any addresses. When you connect via MetaMask or WalletConnect, Drain pulls in your address.

Is there anything I misunderstand here?

It seems there's an Unstoppable Domain wallet that is now usable thanks to this PR? If that's the case, can you instead connect to that wallet via WalletConnect?

— Reply to this email directly, view it on GitHub https://github.com/dawsbot/drain/pull/1#issuecomment-1226101261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR74PDKKIBMUISLCBMA6CBTV2ZUQXANCNFSM57NB6XYQ . You are receiving this because you were mentioned.Message ID: @.***>

dawsbot commented 2 years ago

@ayush035 the solution of resolving unstoppable domains at the bottom for the recipient sounds like a useful PR.

Let's do that, I'll close this PR for now since it adds a lot to the web bundle and slows page loads 🙏