search

dawsbot / eth-labels

📃 A public dataset of crypto addresses labeled
https://eth-labels-production.up.railway.app/swagger
MIT License
198 stars 30 forks source link

Pull expanded token names #36

Closed dawsbot closed 5 months ago

dawsbot commented 7 months ago

When a token name is beyond _ characters, it's currently truncated with "..." in the codebase:

https://github.com/dawsbot/evm-labels/blob/367e5f73f52b5f428872131eea99db1abfcb1010/data/etherscan/0x-protocol-ecosystem/tokens.json#L4

The confusing thing is that this expanded name exists nowhere in the DOM. Instead, this expanded name exists within a separate POST request response:

curl 'https://etherscan.io/tokens.aspx/GetTokensBySubLabel'...

The full CURL is not in this issue because it contains my cookie. This POST should only be done for tokens.json files which contain a "...". Most do not need this.

dawsbot commented 5 months ago

BSCScan suffers from this issue as-well:

https://github.com/dawsbot/evm-labels/pull/61/files#diff-578b3222eb7cfd0ea1ab84c0f46543eac5c21d275572a47c232474b90ef1d3bbR61-R69

kylewandishin commented 5 months ago

bscscan uses a similar design to polygon and ftm so we should make a new pr to incorporate the API pulling method and testing.

kylewandishin commented 5 months ago

@dawsbot I think we should close this issue as it is now being tracked by issue #73