incomplete pulling from optimism and potentially etherscan.

dawsbot / eth-labels

📃 A public dataset of crypto addresses labeled

https://eth-labels-production.up.railway.app/swagger

MIT License

198 stars 30 forks source link

incomplete pulling from optimism and potentially etherscan. #45

Closed kylewandishin closed 5 months ago

kylewandishin commented 7 months ago

this matches with our combined.json in /data/basescan which has a length of 6318

this does NOT match our combined.json in /data/optimism which only has a length of 2467 which is 101 records short.

dawsbot commented 7 months ago

Hey @kylewandishin I am only now seeing this and I simplified that file to only write combined.json files for labels which had more than one json in it.

In that process I removed this code you're mentioning here. Can you describe the issue or open a new PR to v1 that fixes this issue? https://github.com/dawsbot/evm-labels/commit/c3b8ada4ac02dcd9d5acddefcf5f345786d3162b#diff-25d84be0fe67b7bbd33fecabee07a00b177e2fea3c873955d89685bfd4f9af14R28

dawsbot commented 5 months ago

I still don't understand this issue @kylewandishin - can you try again to explain what's happening simpler?

kylewandishin commented 5 months ago

@dawsbot this issue was incorrect. I realised just now that this failed to account for the max cap on tokens at 100 and the max cap on accounts

kylewandishin commented 5 months ago

i think we should close this.