dawson-org / dawson-cli

A serverless web framework for Node.js on AWS (CloudFormation, CloudFront, API Gateway, Lambda)
https://dawson.sh
GNU General Public License v3.0
712 stars 25 forks source link

An in-range update of pre-commit is breaking the build 🚨 #94

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 1.2.2 of pre-commit just got published.

Branch Build failing 🚨
Dependency pre-commit
Current Version 1.2.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As pre-commit is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:


Status Details - ✅ **continuous-integration/travis-ci/push** The Travis CI build passed [Details](https://travis-ci.org/dawson-org/dawson-cli/builds/183566821) - ✅ **coverage/coveralls** First build on greenkeeper/pre-commit-1.2.2 at 70.522% [Details](https://coveralls.io/builds/9255536) - ❌ **ci/circleci** Your tests failed on CircleCI [Details](https://circleci.com/gh/dawson-org/dawson-cli/110?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
Commits

The new version differs by 2 commits .

  • bf393ad [dist] 1.2.2
  • 675560c Use string instead of int 777 in fs.chmodSync so it gets correctly interpreted as octal (#90)

See the full diff.

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 1.2.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

lusentis commented 7 years ago

circleci was not configured correctly and test were failing.