dawsonjon / PicoRX

Build a SDR SW/MW/LW Receiver with a Raspberry Pi Pico
Other
252 stars 32 forks source link

USB volume fixed at 8. Block I2C updates if display is off #103

Closed penfold42 closed 1 month ago

dawsonjon commented 1 month ago

Cool, thanks.

For simplicity, I think we should probably stick with calling it "volume". I think that the behaviour will be what most people expect. It also avoids the international spelling issue😁

I'm not sure that volume level 8 is the right solution. I think that just tapping off the audio after the AGC without adding any extra gain or attenuation would be preferable. The "half way" AGC is conservative, but the AGC does handle overshoot/saturation gracefully and the difference in perceived loudness isn't that great. If we did want to get closer to a full scale signal, it would be better to increase the AGC setpoint.

penfold42 commented 1 month ago

done

dawsonjon commented 1 month ago

Cheers, that's great 👍