search

daxpedda / sentry-contrib-native

Unofficial bindings to the Sentry Native SDK for Rust.
Other
7 stars 6 forks source link

Use event interfaces #30

Open daxpedda opened 3 years ago

daxpedda commented 3 years ago

Currently Event::add_exception and Event::add_stacktrace don't follow Sentry's exception interface properly.

With sentry-native 0.4.9 this was fixed. While updating I noticed to adapt to this change in sentry-contrib-native, I will need to do a rather large refactoring. Considering that the original plan was to integrate this into the Sentry's Rust crate, see https://github.com/getsentry/sentry-rust/issues/299, I would like to leave everything as it is, as integration into Sentry's Rust crate will remove these interfaces entirely.

That said, I'm open to any user-input to tell me otherwise.

daxpedda commented 3 years ago

@Jake-Shadle I just saw that Embark is using a pure breakpad alternative, do you guys plan to upstream this to sentry-rust?

Jake-Shadle commented 3 years ago

Oops, I somehow missed this notification, sorry for the late response! I don't think we'll be upstreaming the breakpad integration itself into the sentry-rust repo (unless they actually want to maintain it), but rather just have a separate repo with an integration that works with the regular sentry API. Just missing the API pieces right now which is why we had to fork.

daxpedda commented 3 years ago

There currently is a lot of activity in Sentry moving a lot of Breakpad parts to pure Rust alternatives. https://github.com/getsentry/symbolic/issues/375 Let's hope my crate will become obsolete :rocket: