search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
798 stars 147 forks source link

Opening datepicker-dropdown popover sometimes shifts its anchor #119

Closed p-himik closed 7 years ago

p-himik commented 7 years ago

When you have an anchor very close to the bottom of the browser window, opening the popover will insert its tag before the anchor which will result in shifted anchor. Same behavior in the latest Google Chrome and Firefox. Bottom right of the image - the popover with removed z-index. dropdown-problem

Gregg8 commented 7 years ago

A new feature was added to the popover component so that if it detects there is not enough room in it's current position, it adjusts the position so it can be seen. There is a problem with popovers that have :no-clip? set (datepicker-dropdown sets this to true). They are adjusted but not perfectly. I have posted issue #113 and this should be addressed when that is completed.

Gregg8 commented 7 years ago

Although I placed 2 datepicker-dropdown components on top of each other using the current re-com version, I couldn't get the results above.

However, #113 has now been fixed so you should try the latest to see if it sorts your issue.

Gregg8 commented 7 years ago

OK, 1.1.0 had a flaw which affects this issue.

Now fixed in 1.2.0. Make sure to test using this new version.