day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
797 stars 147 forks source link

Typeahead dropdown list doesn't shift content underneath anymore (abs… #140

Closed nidu closed 7 years ago

nidu commented 7 years ago

…olute position)

Dropdown is now wrapped in position:relative div and is position:absolute itself so shouldn't shift content underneath. Moreover if input is restyled to have smaller height list should adjust naturally.

Not sure if setting style for wrapping div inside cljs (not css) is a good idea but this thing is small and shouldn't be customizable thus brings no harm i uppose.

nidu commented 7 years ago

Fixes issue #130

Gregg8 commented 7 years ago

I have tested this in re-demo and it works as advertised, so I'm happy to merge.

Perhaps others who use this in production could try this as a final test?

If I don't hear back by the end of the week, I'll merge anyway :-)

Gregg8 commented 7 years ago

Thank you.