When adding a :tooltip to a [hyperlink] the :label gets indented

day8 / re-com

A ClojureScript library of reusable components for Reagent

https://re-com.day8.com.au

MIT License

797 stars 146 forks source link

When adding a :tooltip to a [hyperlink] the :label gets indented #149

Closed mmower closed 7 years ago

mmower commented 7 years ago

I have the following Hiccup structure:

[v-box :children [[label :label "Foo"]
                   [hyperlink :label "Bar"]]]

Which renders Foo and Bar in a vertical column. However if I amend it to:

[v-box :children [[label :label "Foo"]
                   [hyperlink :label "Bar" :tooltip "Baz"]]]

Now the label "Bar" is offset 100px to the right.

macOS 10.12.4 Chrome 58.0.3029.110 re-com 2.0.0 re-frame 0.9.2 reagent 0.6.1 clojurescript 1.9.542

Gregg8 commented 7 years ago

Thanks for pointing this out. It's now fixed, and the same fix has been applied to other button-type components as they would also have had the same issue. The fix does lead to possible breaking changes. See the release notes for details.