search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
797 stars 147 forks source link

async dep broken in newer Clojure alphas #154

Closed deg closed 3 years ago

deg commented 7 years ago

I just added re-com into a new Luminus-based project, where I had updated dependencies including to Clojure 1.9. Re-com broke my build, and the stack trace was awkward enough to make me head-scratch for too many minutes.

The problem was that the version of core.async included in re-com does not work in Clojure 1.9 Alpha15 or later.

I fixed in my project with an explicit include of core.async 0.3.443. I've not tested enough to know if re-com can safely upgrade its dependency. Great if it can. If not, please add a warning to the readme.

awb99 commented 4 years ago

core.async dependency in re-com also makes it impossible to use re-com in self-hosted clojurescript.

BHConsulting commented 4 years ago

Unsubscribe

On Wed, 1 Apr. 2020, 08:06 awb99, notifications@github.com wrote:

core.async dependency in re-com also makes it impossible to use re-com in self-hosted clojurescript.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/day8/re-com/issues/154#issuecomment-606875392, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEJKWV2PDUSILZ74K3MAW23RKJLNFANCNFSM4DQUF3EA .

superstructor commented 3 years ago

Has been upgraded to 1.3.610.