search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
797 stars 147 forks source link

fn? validator fails for r/partial'ed functions #163

Closed dustingetz closed 3 years ago

dustingetz commented 6 years ago

image

dustingetz commented 6 years ago

An easier flag to disable the validator macro in debug builds would be helpful also

dustingetz commented 6 years ago

Paste goog.DEBUG=false in dev console to work around this - works for us - not sure the consequences

khardenstine commented 6 years ago

This was an issue when using reagent < 0.7.0 Their PartialFn did not implement cljs.core.Fn. This has since changed in release 0.7.0: https://github.com/reagent-project/reagent/pull/303/commits/3cf045dc8264373d93d9c3a7607dc2a349194681

mike-thompson-day8 commented 3 years ago

I'm spring cleaning issues. This one appears to be very old, and the root cause seems to be outside of re-com and, anyway, is now fixed. All of which means I'm closing.