search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
796 stars 147 forks source link

Adding focus open and blur close and bug fix for empty string search #174

Closed matthewdaniel closed 5 years ago

matthewdaniel commented 6 years ago

Let me know if you want this split up into multiple PRs but this does 3 small things.

1.) Address issue #141 2.) Add flag for menu on focus 3.) Fix bug where menu shows search results for last character when all characters are cleared

I'm also new to clojure so let me know if you want me to change anything else on the PR.

Gregg8 commented 5 years ago

Thanks for your PR :-) As it happens, the issue in #141 has been addressed by PR #168. It also addressed the bug fix (3) by presenting the search results for ALL items which we'll go for as well. Will close this for now, but do comment/reopen if required.