search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
796 stars 147 forks source link

Empty typeahead throws errors for keyboard events #195

Closed jindrichmynarz closed 5 years ago

jindrichmynarz commented 5 years ago

When the typeahead component is in focus and empty and the user presses arrow up or down it throws an error "No item NaN in vector of length 0". When tab is pressed, "No protocol method IAssociative.-assoc defined for type string:" is thrown. The tab problem is fixed by #194

This can be reproduced in the re-com demo.

itaysabato commented 5 years ago

Any hope of fixing this soon? Is there a workaround?

itaysabato commented 5 years ago

I'm getting a different error on tab BTW:

TypeError: suggestion_to_string is null typeahead.cljs:79:8
    display_suggestion typeahead.cljs:79
    external_model_changed typeahead.cljs:163
    ...
Gregg8 commented 5 years ago

@jindrichmynarz, this has been mostly fixed by #196. You also mention the TAB issue which is being handled by #194 but that's not sorted as yet, so I left this open for now.

Gregg8 commented 5 years ago

194 now merged