day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
796 stars 147 forks source link

Update property to read when handling keyboard events #197

Closed Gregg8 closed 7 months ago

Gregg8 commented 5 years ago

When determining what key was pressed in keyboard event handlers, we examine various properties:

Both of these are now deprecated, so they should all be switched to use the key property - info

Thanks to: https://github.com/Day8/re-frame-10x/issues/231

Frozenlock commented 5 years ago

Some additional info, in case it would be useful:

keyCode is supported by all browsers. (According to caniuse.com)

key not as much. https://caniuse.com/#search=keyboardevent.key