search

day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
796 stars 147 forks source link

datepicker-dropdown cannot be styled. Existing :class and :attr args are passed to dropped down datepicker #215

Closed hipitihop closed 3 years ago

hipitihop commented 3 years ago

The dropdown datepicker cannot be styled. The existing :class and :attr args are passed to the dropped down datepicker. In this example the `"foobar" class end up on the datepicker dv, not on the wrapper/label/activator.

 [rc/datepicker-dropdown
   :class   "foobar"
   :model   my-date-model
   :format  date/wc-date-format
   :on-change  #(dispatch [::date-changed {:new-date %}])]

Perhaps we want to consider adding additional args to support styling and attributes for the wrapper.

Also see https://github.com/day8/re-com/issues/216

superstructor commented 3 years ago

This is fixed as of 2.12.0 or later with :parts arg. See https://re-com.day8.com.au/#/date