day8 / re-com

A ClojureScript library of reusable components for Reagent
https://re-com.day8.com.au
MIT License
796 stars 147 forks source link

Suggested changes to simple-v-table demo #242

Closed mike-thompson-day8 closed 3 years ago

mike-thompson-day8 commented 3 years ago

image

mike-thompson-day8 commented 3 years ago

Also:

  1. Add a "units" column to the right of existing. just to get more width, to make the horizontal scrollbar operation more interesting when :max-table-width is being scrolled by user (see suggestion above in screenshot).
  2. When :max-rows is turned off (via a tickbox) the table will expand vertically as far as it can. So you might need to set container height. Maybe. Put some text in explaining this. Ie. when the tickbox is ticked, show the slider, and when it is not ticked show text explaining how the size is now constrained by the container and will expand as much as possible.
Gregg8 commented 3 years ago

Add more padding between the elements (and more vertical spacing?)

image

Also, add :align-center to those h-boxes to improve their positioning

Gregg8 commented 3 years ago

image